----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37704/#review96132 -----------------------------------------------------------
Ship it! Minor comments, but looks good otherwise! helix-archetype/README.md (line 31) <https://reviews.apache.org/r/37704/#comment151386> Update references to point to the Apache repo. helix-archetype/README.md (line 95) <https://reviews.apache.org/r/37704/#comment151387> Maybe also include some cleanup instructions? helix-archetype/src/main/resources/archetype-resources/pom.xml (line 23) <https://reviews.apache.org/r/37704/#comment151388> whitespace helix-archetype/src/test/conf/testng.xml (line 24) <https://reviews.apache.org/r/37704/#comment151389> a couple whitespace issues in this file - Kanak Biscuitwala On Aug. 23, 2015, 5:17 p.m., Greg Brandt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37704/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2015, 5:17 p.m.) > > > Review request for helix. > > > Repository: helix-git > > > Description > ------- > > Generates a simple OnlineOffline application via the command: > > ``` > mvn archetype:generate \ > -DarchetypeGroupId=org.apache.helix \ > -DarchetypeArtifactId=helix-archetype \ > -DarchetypeVersion=0.7.2-SNAPSHOT \ > -DgroupId=com.example \ > -DartifactId=my-app \ > -Dname=MyApp \ > -DinteractiveMode=false > ``` > > > Diffs > ----- > > helix-archetype/.gitignore PRE-CREATION > helix-archetype/README.md PRE-CREATION > helix-archetype/pom.xml PRE-CREATION > helix-archetype/src/main/resources/META-INF/maven/archetype-metadata.xml > PRE-CREATION > helix-archetype/src/main/resources/archetype-resources/pom.xml PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/java/__name__Main.java > PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/java/participant/__name__Participant.java > PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/java/participant/__name__StateTransitionHandler.java > PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/java/participant/__name__StateTransitionHandlerFactory.java > PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/java/spectator/__name__Spectator.java > PRE-CREATION > > helix-archetype/src/main/resources/archetype-resources/src/main/resources/log4j.xml > PRE-CREATION > helix-archetype/src/test/conf/testng.xml PRE-CREATION > pom.xml 4faf806 > > Diff: https://reviews.apache.org/r/37704/diff/ > > > Testing > ------- > > mvn test -pl helix-archetype # passes > mvn mvn -Prat -DskipTests -pl helix-archetype # passes > > > Thanks, > > Greg Brandt > >
