Github user jiajunwang commented on a diff in the pull request:
https://github.com/apache/helix/pull/88#discussion_r117135837
--- Diff: helix-core/src/main/java/org/apache/helix/task/JobRebalancer.java
---
@@ -420,6 +411,14 @@ private ResourceAssignment
computeResourceMapping(String jobResource,
workflowConfig, workflowCtx, allPartitions,
cache.getIdealStates());
for (Map.Entry<String, SortedSet<Integer>> entry :
taskAssignments.entrySet()) {
String instance = entry.getKey();
+
+ if (!isGenericTaskJob(jobCfg) || jobCfg.isRebalanceRunningTask()) {
--- End diff --
Why is this logic in the for loop? Do we need to execute it for each
<instance, partitions> entry?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
