[
https://issues.apache.org/jira/browse/HELIX-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397844#comment-16397844
]
ASF GitHub Bot commented on HELIX-674:
--------------------------------------
Github user mcvsubbu commented on a diff in the pull request:
https://github.com/apache/helix/pull/145#discussion_r174310141
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/constraint/dataprovider/ZkBasedCapacityProvider.java
---
@@ -0,0 +1,202 @@
+package org.apache.helix.controller.rebalancer.constraint.dataprovider;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.helix.*;
+import
org.apache.helix.api.rebalancer.constraint.dataprovider.CapacityProvider;
+import org.apache.helix.manager.zk.ZNRecordSerializer;
+import org.apache.helix.store.zk.ZkHelixPropertyStore;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A capacity provider based on ZK node.
+ * This class support persistent through Helix Property Store.
+ */
+public class ZkBasedCapacityProvider implements CapacityProvider {
+ public static final int DEFAULT_CAPACITY_VALUE = 0;
+ private static final String ROOT = "/PARTICIPANT_CAPACITY";
+
+ private final ZkHelixPropertyStore<ZNRecord> _propertyStore;
+ private final String _dimensionPath;
+ private ParticipantCapacity _capacity;
+
+ /**
+ * @param propertyStore The store that will be used to persist capacity
information.
+ * @param dimensionName Identify of the capacity attribute. For example
memory, CPU.
+ */
+ public ZkBasedCapacityProvider(ZkHelixPropertyStore<ZNRecord>
propertyStore,
+ String dimensionName) {
+ _propertyStore = propertyStore;
+ _dimensionPath = ROOT + "/" + dimensionName;
+
+ ZNRecord existingRecord = _propertyStore.get(_dimensionPath, null,
AccessOption.PERSISTENT);
+ if (existingRecord == null) {
+ // Create a capacity object using default capacity
(DEFAULT_CAPACITY_VALUE).
+ _capacity = new ParticipantCapacity(dimensionName);
+ } else {
+ _capacity = new ParticipantCapacity(existingRecord);
+ }
+ }
+
+ /**
+ * @param zkAddr
+ * @param clusterName
+ * @param dimensionName Identify of the capacity attribute. For example
memory, CPU.
+ * Need to match resource quota dimension.
+ */
+ public ZkBasedCapacityProvider(String zkAddr, String clusterName, String
dimensionName) {
+ this(new ZkHelixPropertyStore<ZNRecord>(zkAddr, new
ZNRecordSerializer(),
+ PropertyPathBuilder.propertyStore(clusterName)), dimensionName);
+ }
+
+ /**
+ * Update capacity information.
+ *
+ * @param capacityMap <ParticipantName, Total Participant Capacity>
+ * @param usageMap <ParticipantName, Provisioned Capacity>
+ * @param defaultCapacity Default total capacity if not specified in the
map
+ */
+ public void updateCapacity(Map<String, Integer> capacityMap, Map<String,
Integer> usageMap,
+ int defaultCapacity) {
+ for (String participant : capacityMap.keySet()) {
+ _capacity.setCapacity(participant, capacityMap.get(participant));
+ }
+ for (String participant : usageMap.keySet()) {
+ _capacity.setUsage(participant, usageMap.get(participant));
+ }
+ _capacity.setDefaultCapacity(defaultCapacity);
+ }
+
+ /**
+ * @return True if the capacity information is successfully wrote to ZK.
+ */
+ public boolean persistCapacity() {
+ if (_capacity.isValid()) {
+ return _propertyStore.set(_dimensionPath, _capacity.getRecord(),
AccessOption.PERSISTENT);
+ } else {
+ throw new HelixException("Invalid ParticipantCapacity: " +
_capacity.getRecord().toString());
+ }
+ }
+
+ @Override
+ public int getParticipantCapacity(String participant) {
+ return _capacity.getCapacity(participant);
+ }
+
+ @Override
+ public int getParticipantProvisioned(String participant) {
+ return _capacity.getUsage(participant);
+ }
+
+ /**
+ * Data model for participant capacity.
+ * Per-participant capacity and usage are recorded in the mapfields.
+ */
+ private static class ParticipantCapacity extends HelixProperty {
+ private static final String CAPACITY = "CAPACITY";
--- End diff --
See comments before on interface CapacityProvider.
> Constraint Based Resource Rebalancer
> ------------------------------------
>
> Key: HELIX-674
> URL: https://issues.apache.org/jira/browse/HELIX-674
> Project: Apache Helix
> Issue Type: New Feature
> Reporter: Jiajun Wang
> Assignee: Jiajun Wang
> Priority: Major
> Fix For: 0.8.x
>
> Attachments: Constraint-BasedResourceRebalancing-080318-2226-240.pdf
>
>
> Helix rebalancer assigns resources according to different strategies.
> Recently, we optimize the strategy for evenness and minimize movement.
> However, the evenness here only applies to partition numbers. Moreover, we've
> got more requests for customizable rebalancer from our users.
> Take partition weight as an example:
> In reality, partition replicas have different size. We use "partition weight"
> as an abstraction of the partition size. It can be network traffic usage,
> disk usage, or any other combined factors.
> Given each partition may have different weights, Helix should be able to
> assign partition accordingly. So that the distribution would be even
> regarding the weight.
> In this project, we are planning new rebalancer mechanism that generates
> resource partition assignment according to a list of "constraints". Current
> rebalance strategy can be regarded as one kind of constraint. Moving forward,
> Helix users would be able to extend the constraint interface using their own
> logic.
> Some init discussions are in progress and we will have a proposal posted here
> soon.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
