Github user kishoreg commented on a diff in the pull request:

    https://github.com/apache/helix/pull/155#discussion_r176171189
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
    @@ -576,8 +573,8 @@ public void handleDataChange(String dataPath, Object 
data) {
     
       @Override
       public void handleChildChange(String parentPath, List<String> 
currentChilds) {
    -    logger.debug("Data change callback: child changed, path: " + 
parentPath + ", current childs: "
    -        + currentChilds);
    +    logger.info("Data change callback: child changed, path: " + parentPath 
+ ", current child count: "
    --- End diff --
    
    lets avoid constructing strings to reduce GC pressure. Also, this will 
pollute the logs. What are we trying to get out of these log messages


---

Reply via email to