Github user dasahcc commented on a diff in the pull request:

    https://github.com/apache/helix/pull/156#discussion_r176271788
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
 ---
    @@ -121,6 +131,18 @@ public void process(ClusterEvent event) throws 
Exception {
     
               Message message = null;
     
    +          if (shouldCleanUpPendingMessage(pendingMessage, currentState,
    +              currentStateOutput.getEndTime(resourceName, partition, 
instanceName))) {
    +            logger.info(
    +                "Adding pending message {} on instance {} to GC. Msg: 
{}->{}, current state of resource {}:{} is {}",
    --- End diff --
    
    Let's not use GC name for it.


---

Reply via email to