[
https://issues.apache.org/jira/browse/HELIX-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451423#comment-16451423
]
ASF GitHub Bot commented on HELIX-681:
--------------------------------------
GitHub user zhan849 opened a pull request:
https://github.com/apache/helix/pull/197
[HELIX-681] change controller msg purge timeout to larger number
Changed message purge delay to 1min, updated tests accordingly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhan849/helix harry/ctl-msg-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/197.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #197
----
commit 4e02cbb9945279b7085e5c725b9d966b90086cc7
Author: Harry Zhang <zhan849@...>
Date: 2018-04-24T23:46:14Z
[HELIX-681] change controller msg purge timeout to larger number
----
> Participant should not fail state transition on fail to delete / relay message
> ------------------------------------------------------------------------------
>
> Key: HELIX-681
> URL: https://issues.apache.org/jira/browse/HELIX-681
> Project: Apache Helix
> Issue Type: Bug
> Reporter: Hao Zhang
> Priority: Major
>
> Currently we have a general try-catch block in HelixTask and
> HelixTaskExecutor, which, upon any exception thrown from state transition
> routine, will fail state transition. However there are at least the following
> cases in which state transition should be considered as successful:
> * When we fail to delete message after successfully handled message and
> updated current state -> this is because we already completed state
> transition and current state is consistent between participant and ZK
> * When we fail to send out relay message > as relay message provides only
> best effort of delivering messages, which has nothing to do with state
> transition's results. In case of fail to relay message, controller will
> resend message which ensures correctness.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
