GitHub user narendly opened a pull request:

    https://github.com/apache/helix/pull/261

    [TASK] Allow undefined workflow/job types to be assigned as DEFAULT type

    …ULT type
    
    Previously, we ignored undefined types, that is workflow/job types that are 
not defined in ClusterConfig. This is not backward-compatible because some 
users of Task Framework are setting types without any quota-related config set 
in ClusterConfig. The default behavior was changed so that each 
AssignableInstance will just treat these workflows/jobs as DEFAULT type, which 
will make quota-based scheduling backward-compatible.
    Changelist:
    1. AssignableInstance treats undefined types as DEFAULT
    2. Appropriate log messages and logic change was applied to 
restoreTaskAssignResult logic
    3. A test case was added to TestQuotaBasedScheduling

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narendly/helix 1366988

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/261.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #261
    
----
commit b134a0a23b91b304187aa12e660cab8552d246da
Author: Hunter Lee <narendly@...>
Date:   2018-07-24T21:06:20Z

    [HELIX-744] Allow undefined workflow/job types to be assigned as DEFAULT 
type
    
    Previously, we ignored undefined types, that is workflow/job types that are 
not defined in ClusterConfig. This is not backward-compatible because some 
users of Task Framework are setting types without any quota-related config set 
in ClusterConfig. The default behavior was changed so that each 
AssignableInstance will just treat these workflows/jobs as DEFAULT type, which 
will make quota-based scheduling backward-compatible.
    Changelist:
    1. AssignableInstance treats undefined types as DEFAULT
    2. Appropriate log messages and logic change was applied to 
restoreTaskAssignResult logic
    3. A test case was added to TestQuotaBasedScheduling

----


---

Reply via email to