GitHub user narendly opened a pull request:
https://github.com/apache/helix/pull/263
[TASK] Fix removeJob so its behavior is more consistent with removeWorkflow
â¦oveWorkflow
Change the behavior of removeJob() so that it's more consistent with
removeWorkflow(). This RB addresses the scenario: suppose config deletion
failed (so config still exists) and context deletion succeeded. Then the
Controller has no way of knowing whether this job has ever been scheduled or it
was meant to be deleted (although failed due to partial deletion). Returning as
soon as config deletion fails can prevent this scenario.
Changelist:
1. Make removeJob() return early as soon as a ZNode write failure is
detected
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/narendly/helix 1363588
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #263
----
commit d346a25d4efe4a64a55d13acbf05b3d36c72e0c3
Author: Hunter Lee <narendly@...>
Date: 2018-07-24T21:11:50Z
[HELIX-746] Fix removeJob so its behavior is more consistent with
removeWorkflow
Change the behavior of removeJob() so that it's more consistent with
removeWorkflow(). This RB addresses the scenario: suppose config deletion
failed (so config still exists) and context deletion succeeded. Then the
Controller has no way of knowing whether this job has ever been scheduled or it
was meant to be deleted (although failed due to partial deletion). Returning as
soon as config deletion fails can prevent this scenario.
Changelist:
1. Make removeJob() return early as soon as a ZNode write failure is
detected
----
---
