GitHub user mebe opened a pull request:
https://github.com/apache/helix/pull/300
Daemonize SubscribeChangeEventProcessor thread in CallbackProcessor
`CallbackProcessor.SubscribeChangeEventProcessor` is a `DedupEventProcessor
extends Thread`. It is started in a static initializer in `CallbackProcessor`
and never shut down.
This causes process JVM shutdown to never finish as this thread is hanging.
There is no obvious place to shut down the `SubscribeChangeEventProcessor`
thread. I propose fixing this by making it a daemon thread. This causes the
thread to be abandoned at shutdown. But this might have some unwanted side
effects?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mebe/helix
daemonize-SubscribeChangeEventProcessor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit fd7b28fece994e7b22ae0428faae9da203b24ee4
Author: Iikka Niinivaara <iikka.niinivaara@...>
Date: 2019-02-05T18:12:22Z
Daemonize SubscribeChangeEventProcessor thread in CallbackProcessor
----
---
