jiajunwang commented on a change in pull request #336: #334 Fix invoke
rebalance by "touching" IdealState/ResourceConfig
URL: https://github.com/apache/helix/pull/336#discussion_r303740523
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceScheduler.java
##########
@@ -138,7 +140,7 @@ public static void invokeRebalance(HelixDataAccessor
accessor, String resource)
PropertyKey key = accessor.keyBuilder().idealStates(resource);
IdealState is = accessor.getProperty(key);
if (is != null) {
- if (!accessor.updateProperty(key, is)) {
+ if (!accessor.updateProperty(key, znRecord -> znRecord, is)) {
Review comment:
I guess this might be hard for those who are not familiar with the accessor
to understand. Please either comment with some detail, such as version based
update, or just create a new call "idleUpdateProperty" or so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
