alirezazamani commented on a change in pull request #337: Fixing
IllegalStateException for CRUSH based rebalance strategy algorithm.
URL: https://github.com/apache/helix/pull/337#discussion_r304500966
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -259,7 +259,7 @@ private boolean
computeResourceBestPossibleState(ClusterEvent event, ResourceCon
return checkBestPossibleStateCalculation(idealState);
} catch (Exception e) {
LogUtil
- .logError(logger, _eventId, "Error computing assignment for
resource " + resourceName + ". Skipping.", e);
+ .logError(logger, _eventId, "Error computing assignment for
resource " + resourceName + ". Skipping.");
Review comment:
You are right. But the problem is the discrepancy between default rebalance
strategy and CRUSH based. As I understand from the issue, in the same situation
we do not show exception in the default rebalance strategy. In my opinion, we
should show exception either in both cases or in non of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
