dasahcc commented on a change in pull request #346: Unwanted logs have been
removed.
URL: https://github.com/apache/helix/pull/346#discussion_r305574275
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/CrushRebalanceStrategy.java
##########
@@ -89,7 +89,16 @@ public ZNRecord computePartitionAssignment(final
List<String> allNodes,
long data = partitionName.hashCode();
// apply the placement rules
- List<Node> selected = select(topNode, data, _replicas, eventId);
+ List<Node> selected;
+ try {
+ selected = select(topNode, data, _replicas, eventId);
+ } catch (IllegalStateException e) {
+ String errorMessage = String
+ .format("Could not select enough number of nodes. %s partition %s,
required %d",
+ _resourceName, partitionName, _replicas);
+ LogUtil.logError(Log, eventId, errorMessage);
Review comment:
I think it better to read the code completely or you have some understanding
of Helix pipeline. This exception will be handled in BestPossibleStage. It was
designed for not breaking the pipeline which will impact the computation for
rest of other resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
