narendly commented on issue #326: Add getWorkflow(long timeout) to TaskDriver URL: https://github.com/apache/helix/issues/326#issuecomment-513569098 Feel free to contribute. I have not started working on it yet. The implementation should be straightforward and I could help with the review. Hunter Sent from BlueMail On Jul 21, 2019, 18:36, at 18:36, pkuwm <[email protected]> wrote: >Thanks. Are you working on it? If not, may I take this ticket and >contribute? > >On Sun, Jul 21, 2019 at 1:33 AM Hunter Lee <[email protected]> >wrote: > >> It is a typo - it is getWorkflows(). For now, only adding >getWorkflows >> (timeout) would suffice. >> >> Hunter >> >> Sent from BlueMail >> >> On Jul 21, 2019, 09:58, at 09:58, pkuwm <[email protected]> >wrote: >> >I don't see the call: getWorkflow() in the source code. Did you >mean >> >[getWorkflows]( >> >https://github.com/apache/helix/blob/3e670ded2ece50e21b76fcab7fed7cb61a24eea1/helix-core/src/main/java/org/apache/helix/task/TaskDriver.java#L836)( >> )? >> > >> > public Map<String, WorkflowConfig> getWorkflows() >> > >> >Do you think it is alright to have a default timeout for the >current >> >call getWorkflows() and also add a new api getWorkflow(long timeout) >? >> > >> >-- >> >You are receiving this because you authored the thread. >> >Reply to this email directly or view it on GitHub: >> >https://github.com/apache/helix/issues/326#issuecomment-513532438 >> >> — >> You are receiving this because you commented. >> Reply to this email directly, view it on GitHub >> ><https://github.com/apache/helix/issues/326?email_source=notifications&email_token=ABHSRCMUIWK4GLYKEMRBCBLQAQNLZA5CNFSM4H36DXA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2N6VNA#issuecomment-513534644>, >> or mute the thread >> ><https://github.com/notifications/unsubscribe-auth/ABHSRCPE4YIBD6LQSD3XVITQAQNLZANCNFSM4H36DXAQ> >> . >> > > >-- >You are receiving this because you authored the thread. >Reply to this email directly or view it on GitHub: >https://github.com/apache/helix/issues/326#issuecomment-513568933
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
