pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-514106193 Right. I was actually considering that. But it seems after checking isWFConfig, parsing is still needed. To me it seems redundant. If other places could call isWFConfig, maybe we can have a isWFConfig and use fromHelixProperty to parse the property after checking? On Tue, Jul 23, 2019 at 1:16 AM Hunter Lee <[email protected]> wrote: > As for parseWorkflow - I think it will be cleaner if we could have > something like isWorkflowConfig() instead that returns T/F, and based on > the result, include it here or not. This way, we do not return null (a code > smell), and there are other places in the codebase where we could re-use > isWorkflowConfig. > > On Jul 23, 2019, 10:02, at 10:02, pkuwm <[email protected]> wrote: > >Wonder what the unit test requirement is. Can you please suggest? > > > >-- > >You are receiving this because you are subscribed to this thread. > >Reply to this email directly or view it on GitHub: > >https://github.com/apache/helix/pull/357#issuecomment-514099797 > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/helix/pull/357?email_source=notifications&email_token=ABHSRCLNW6B7I5GKE2CP6M3QA247HA5CNFSM4IGBGEJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SJ2GQ#issuecomment-514104602>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABHSRCP23KGM5PJHQDOFONLQA247HANCNFSM4IGBGEJA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
