jiajunwang commented on a change in pull request #357: [WIP] Add
getWorkflows(long timeout) to TaskDriver.
URL: https://github.com/apache/helix/pull/357#discussion_r306560312
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java
##########
@@ -850,6 +858,56 @@ public static JobConfig getJobConfig(HelixManager
manager, String job) {
return workflowConfigMap;
}
+ /**
+ * Batch get the configurations of all workflows in this cluster
+ * within the specified timeout in milliseconds.
+ *
+ * @param timeout a long integer presents the timeout, in milliseconds
+ * @return a map of <String, WorkflowConfig>
+ * @throws InterruptedException if the future thread was interrupted
+ * @throws ExecutionException if the future task completed exceptionally
+ * @throws TimeoutException if waiting for result timed out
+ */
+ public Map<String, WorkflowConfig> getWorkflows(long timeout)
+ throws CancellationException, InterruptedException, ExecutionException,
TimeoutException {
+ if (timeout <= 0L) {
+ throw new IllegalArgumentException("timeout must be positive.");
+ }
+
+ ExecutorService executorService = Executors.newSingleThreadExecutor();
Review comment:
It is not related to how frequently it is called. And in reality, we don't
know. It depends on our customer application's logic. We need to reasonably
optimize our code to support the possible use cases.
In addition, for caching the result, you need to think about how to refresh
the cache when things changed. Probably be too complicated here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
