narendly commented on issue #360: Romve TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#issuecomment-514748462 Fix typo in title? :) On Jul 24, 2019, 20:31, at 20:31, Junkai Xue <[email protected]> wrote: >dasahcc commented on this pull request. > > > >> @@ -263,19 +263,6 @@ private boolean >computeResourceBestPossibleState(ClusterEvent event, ResourceCon > } catch (Exception e) { > LogUtil.logError(logger, _eventId, >"Error computing assignment for resource " + resourceName + ". >Skipping."); >- // TODO : remove this part after debugging NPE > >Have you add NPE checks for partition assignment? > >-- >You are receiving this because you are subscribed to this thread. >Reply to this email directly or view it on GitHub: >https://github.com/apache/helix/pull/360#pullrequestreview-266207254
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
