i3wangyi commented on a change in pull request #359: Dynamically change the
processor thread name when consuming event
URL: https://github.com/apache/helix/pull/359#discussion_r306977670
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1165,7 +1164,11 @@ public void run() {
+ _processorName);
while (!isInterrupted()) {
try {
- handleEvent(_eventBlockingQueue.take(), _cache);
+ ClusterEvent newClusterEvent = _eventBlockingQueue.take();
+ // rename the current processor's thread name to include event id
+ String currentThreadName = this.getName().split("_")[0];
+ this.setName(currentThreadName + "_" + newClusterEvent.getEventId());
+ handleEvent(newClusterEvent, _cache);
Review comment:
Setting name before and after handle event is clearer to me. Because it is
outside of handling logic and it clearly indicates the start and end position
of thread renaming.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
