pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long
timeout) to TaskDriver.
URL: https://github.com/apache/helix/pull/357#discussion_r307010167
##########
File path: helix-core/src/main/java/org/apache/helix/task/WorkflowConfig.java
##########
@@ -322,6 +322,22 @@ public static WorkflowConfig
fromHelixProperty(HelixProperty property)
return Builder.fromMap(configs).setWorkflowId(property.getId()).build();
}
+ /**
+ * Build a WorkflowConfig from a HelixProperty.
+ *
+ * @param property a HelixProperty
+ * @return a WorkflowConfig if the property is a valid WorkflowConfig.
+ * Otherwise return null
+ */
+ public static WorkflowConfig parseWorkflowConfig(HelixProperty property)
+ throws IllegalArgumentException {
+ Map<String, String> configs = property.getRecord().getSimpleFields();
+ if (!configs.containsKey(WorkflowConfigProperty.Dag.name())) {
Review comment:
My preference would be to use number 0 to represent timeout disabled. I see
quite many timeout settings are designed like this, ex, in Hadoop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
