i3wangyi commented on a change in pull request #348: Adding the configuration
items of the WAGED rebalancer.
URL: https://github.com/apache/helix/pull/348#discussion_r307456889
##########
File path: helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
##########
@@ -505,6 +505,46 @@ public void setMaxConcurrentTask(int maxConcurrentTask) {
_record.setIntField(InstanceConfigProperty.MAX_CONCURRENT_TASK.name(),
maxConcurrentTask);
}
+ /**
+ * Get the instance capacity information from the map fields
+ * @return data map if it exists, or empty map
+ */
+ public Map<String, Integer> getInstanceCapacityMap() {
+ Map<String, String> capacityData =
_record.getMapField(InstanceConfigProperty.INSTANCE_CAPACITY_MAP.name());
Review comment:
Current getMapField impl is
```
public Map<String, String> getMapField(String k) {
return mapFields.get(k);
}
```
if you make it
```
public Map<String, String> getMapField(String k) {
return mapFields.getOrDefault(k, new HashMap<>());
}
```
I don't think it cause backward compability issue and you won't need to
check if map == null everywhere. For those who already checks, it doesn't hurt.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
