jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider
statePropagationLatency metric reporting bug
URL: https://github.com/apache/helix/pull/365#discussion_r309558774
##########
File path:
helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java
##########
@@ -558,23 +558,29 @@ protected void refresh(Map<String, Map<String,
Map<String, CurrentState>>> curre
private void resetRoutingTableAndNotify(long startTime, RoutingTable
newRoutingTable) {
_routingTableRef.set(newRoutingTable);
- logger.info("Refresh the RoutingTable for cluster {}, takes {} ms.",
- (_helixManager != null ? _helixManager.getClusterName() : null),
+ String clusterName = _helixManager != null ?
_helixManager.getClusterName() : null;
+ logger.info("Refresh the RoutingTable for cluster {}, takes {} ms.",
clusterName,
(System.currentTimeMillis() - startTime));
- notifyRoutingTableChange();
+
+ // TODO: move the callback user code logic to separate thread upon testing
result
Review comment:
There is a chance that this TODO will stay here for a while. When we
revisit, people might forget what testing we were talking about. Please be more
specific.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
