alirezazamani opened a new pull request #371: Remove unnecessary touch logic issues that forces triggering Helix pipelines URL: https://github.com/apache/helix/pull/371 **Issues** In the places that ZooKeeper Resourceconfig is updated, it is not necessary to do touch logic anymore to run the pipeline again. (#370) **Description** An update in Resourcesconfig in the ZooKeeper automatically triggers pipeline (since Helix controller gets notified). Hence, after updating Resourceconfig, there is no need do touch logic anymore. **Tests** Test result 1: mvn test [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestAlertingRebalancerFailure.testTagSetIncorrect:174->checkResourceBestPossibleCalFailureState:310 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 835, Failures: 1, Errors: 0, Skipped: 1 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 55:06 min [INFO] Finished at: 2019-08-01T11:54:04-07:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures. [ERROR] [ERROR] Please refer to /home/anajari/my_repos/helix/helix-core/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Test result 2: mvn test -Dtest="TestAlertingRebalancerFailure" [INFO] Results: [INFO] [INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 8.522 s [INFO] Finished at: 2019-08-01T12:06:38-07:00 [INFO] ------------------------------------------------------------------------ **Commits** In this commit, unnecessary touch logics has been identified and removed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
