i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#issuecomment-517548807 > Some concerns: > > 1. What would help others see that you aren't breaking any features is to keep existing tests the same (not modify any existing tests - adding new test cases is encouraged, however). Could we minimize changes to existing tests? > 2. Do we have the test result? Like I've replied inline, if you look a little careful, I just make the `validate` method more visible and didn't change any verification methods. I need it cause TestHelper expects a boolean returned interface. The test result is in the second comment and I've just updated it.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
