i3wangyi commented on a change in pull request #369: Add the workaround fix for
assigning partitions when instance weight …
URL: https://github.com/apache/helix/pull/369#discussion_r309983555
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Node.java
##########
@@ -36,6 +36,11 @@
public Node() { }
+ public Node(String name, long id) {
Review comment:
That's the problem of using not final field, I don't know what are must-have
fields which are set later. Given we have all set methods for the rest of
fields, I'm not making it worse by only selecting interesting fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
