narendly commented on a change in pull request #333: Fix issue when client only
sets ANY at cluster level throttle config
URL: https://github.com/apache/helix/pull/333#discussion_r310150588
##########
File path:
helix-core/src/test/java/org/apache/helix/integration/TestPartitionMovementThrottle.java
##########
@@ -279,13 +332,15 @@ public void testResourceThrottleWithDelayRebalancer() {
Assert.assertTrue(_clusterVerifier.verifyByPolling());
for (String db : _dbs) {
- validateThrottle(DelayedTransition.getResourcePatitionTransitionTimes(),
db, 2);
+ int maxInParallel =
getMaxParallelTransitionCount(DelayedTransition.getResourcePatitionTransitionTimes(),
db);
+ System.out.println(
+ "MaxInParallel: " + maxInParallel + " maxPendingTransition: " + 2);
+ Assert.assertTrue(maxInParallel <= 2, "Throttle condition does not meet
for " + db);
}
}
- private void validateThrottle(
Review comment:
@i3wangyi You make a great point. Thanks for clarifying and I believe this
is the correct thing to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
