narendly commented on a change in pull request #369: Add the workaround fix for 
assigning partitions when instance weight …
URL: https://github.com/apache/helix/pull/369#discussion_r310234688
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Node.java
 ##########
 @@ -36,6 +36,11 @@
 
   public Node() { }
 
+  public Node(String name, long id) {
 
 Review comment:
   I think this is a minor point. Alternatively, you could just use the empty 
constructor and call set methods but either way I think would work? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to