2012/12/16 Patrick Hunt <[email protected]>:
> Good work. -1 at the moment for the following:
>
> the archive seems to be including a GPL licensed library. From the src 
> archive:
> ./helix-core/src/main/scripts/integration-test/testcases/shiftone-jrat.jar
> which seems to be:
> http://jrat.sourceforge.net/lesser.html
> Apache releases cannot include GPL'd software.
Arg I missed this one.
>
> Have you verified the license for all other files you are including in
> your src release artifact and binary convenience artifacts?
I spend some time to check (but I can miss files due to human manual mode :-) ).
>
> the status page for the project is not up to date:
> http://incubator.apache.org/projects/helix.html
>
> The release should be named apache-helix-*
> http://incubator.apache.org/guides/releasemanagement.html#naming
sure
>
agree.
> Why are some of the files .tar and some .zip. Would be nice to be
> consistent. Also gzip the tar files. (not a blocker but would be good
> to cleanup)

>
> a couple of scripts are missing license headers: (don't exclude these
> in your rat check in pom.xml)
>   ./bump-up.command
>   ./deploySite.sh
>
> in helix-admin-webapp-0.6-incubating and helix-core-0.6-incubating the
> NOTICE seems to be for a different project?
>
my bad I copied file from an other project I worked, changed the
content but missed the name :-(

So I cancel this vote.
And will retry an other one.

Thanks for the review !!

> Patrick
>
> On Fri, Dec 14, 2012 at 4:32 PM, Olivier Lamy <[email protected]> wrote:
>> Hi,
>> I'd like to release Apache Helix 0.6-incubating.
>>
>> Jira closed:
>>
>> ** Bug
>>     * [HELIX-1] - Use org.apache.helix package for java sources.
>>     * [HELIX-2] - Remove jsqlparser dependency from Helix
>>     * [HELIX-3] - Fix license headers in sources.
>>     * [HELIX-14] - error in helix-core ivy file
>>
>> ** Task
>>     * [HELIX-4] - Remove deprecated file based implementation
>>     * [HELIX-5] - Remove deprecated Accessors
>>     * [HELIX-13] - New usecase to replicate files between replicas
>> using simple rsync
>>
>> Maven staged release repository:
>> https://repository.apache.org/content/repositories/orgapachehelix-019/org/apache/helix/helix/0.6-incubating/
>>
>> Distribution:
>> * binaries: 
>> https://dist.apache.org/repos/dist/dev/incubator/helix/0.6-incubating/binaries/
>> * sources: 
>> https://dist.apache.org/repos/dist/dev/incubator/helix/0.6-incubating/src/
>>
>> Vote open for 72H
>>
>> [+1]
>> [0]
>> [-1]
>>
>> Thanks
>> --
>> Olivier Lamy
>> Talend: http://coders.talend.com
>> http://twitter.com/olamy | http://linkedin.com/in/olamy



--
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

Reply via email to