Kishore,

Do you have an opinion on what the changes should be? I am all for removing host and port completely from InstanceConfig.

Vinayak


On 4/2/13 11:09 AM, Vinayak Borkar (JIRA) wrote:

     [ 
https://issues.apache.org/jira/browse/HELIX-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13620084#comment-13620084
 ]

Vinayak Borkar commented on HELIX-73:
-------------------------------------

We could make the host and port optional. However, we still need to be able to 
specify host and port, in addition to the ID, from the command line, correct? 
Or are you leaning towards not being able to specify host and port through the 
command line tools, but only be able to set those programmatically?

One other possibility is to completely remove host and port from 
InstanceConfig. If users want to use host and port, they can do so 
programmatically by setting the value in the ZNRecord in the InstanceConfig. 
Thoughts on that?

Remove assumption that Instance.id is always host_port
------------------------------------------------------

                 Key: HELIX-73
                 URL: https://issues.apache.org/jira/browse/HELIX-73
             Project: Apache Helix
          Issue Type: Improvement
          Components: helix-core
    Affects Versions: 0.6.0-incubating
            Reporter: Vinayak Borkar
             Fix For: 0.6.1-incubating


Currently, some parts of Helix make an assumption that the id of an Instance is 
always made up of a combination of host and port. Can this assumption be 
eliminated? If so, I can work on providing a patch that fixes this issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to