----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11961/ -----------------------------------------------------------
Review request for helix, Kishore Gopalakrishna and Shi Lu. Description ------- 1) separate HelixManager impl for participant, controller, and distributed controller 2) take care of consecutive handleNewSession() and session expiry during handleNewSession() 3) fix HelixManager#isLeader() bug by comparing both instanceName and sessionId 4) a few other fixes Diffs ----- helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java ff45c74 helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java 1b337fd helix-core/src/main/java/org/apache/helix/manager/zk/AbstractHelixManager.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java cfe40c1 helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/HelixController.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/HelixControllerNewSessionHandler.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/HelixDistributedController.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipant.java e69de29 helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipantNewSessionHandler.java e69de29 helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java ba9b400 helix-core/src/test/java/org/apache/helix/integration/TestHelixDistributedController.java e69de29 helix-core/src/test/java/org/apache/helix/integration/TestHelixParticipant.java e69de29 Diff: https://reviews.apache.org/r/11961/diff/ Testing ------- all original tests passed add two new tests: TestHelixParticipant.java TestHelixDistributedController.java both new tests passed Thanks, Zhen Zhang
