> On Aug. 2, 2013, 10:49 p.m., Kishore Gopalakrishna wrote: > > Awesome work, one minor thing is we have too many constructors in ZNRecord. > > Should we make optional arguments into setters ?
I'll make a separate Jira for that. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13193/#review24587 ----------------------------------------------------------- On Aug. 1, 2013, 8:42 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13193/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 8:42 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-107 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-107. Much of the simple field usage was changed to be more > type-specific. ZNRecord can now also accept an arbitrary payload that is > strongly typed. > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/ZNRecord.java c5cb4a6 > > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > 674afa4 > > helix-core/src/main/java/org/apache/helix/manager/zk/serializer/JacksonPayloadSerializer.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/manager/zk/serializer/PayloadSerializer.java > PRE-CREATION > helix-core/src/main/java/org/apache/helix/model/HealthStat.java 29a4e6c > helix-core/src/main/java/org/apache/helix/model/IdealState.java 10d7483 > helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java 9ac594a > helix-core/src/main/java/org/apache/helix/model/Message.java 9d07404 > > helix-core/src/test/java/org/apache/helix/manager/zk/serializer/TestJacksonPayloadSerializer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13193/diff/ > > > Testing > ------- > > Tests passed locally. > > > Thanks, > > Kanak Biscuitwala > >
