Hi Leonnis, I had a question. You have change the packaging from jar to bundle. what does this mean?. I hope it still continues to generate a jar. I was about to apply the patch and see, but thought I would ask away.
thanks, Kishore G On Tue, Aug 6, 2013 at 8:45 AM, Kishore Gopalakrishna <[email protected]>wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13279/ > > Ship it! > > looks good. > > > - Kishore Gopalakrishna > > On August 6th, 2013, 11:18 a.m. UTC, iocanel wrote: > Review request for helix. > By iocanel. > > *Updated Aug. 6, 2013, 11:18 a.m.* > *Repository: * helix-git > Description > > i) OSGi metdata to helix artifacts. > ii) Embeeds PathUtils which is not exported by ZooKeeper. > iii) Fixes a potential classloading issue for OSGi. > > Testing > > Deployment of generated bundles has been tested on Apache Karaf 2.3.1 > > Diffs > > - helix-admin-webapp/pom.xml (0b07881) > - helix-agent/pom.xml (441225f) > - helix-core/pom.xml (bb8ed90) > - > helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java > (9e772ff) > - > helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java > (9eb926d) > - pom.xml (4a60b72) > - recipes/distributed-lock-manager/pom.xml (a331168) > - recipes/rabbitmq-consumer-group/pom.xml (c239ac6) > - recipes/rsync-replicated-file-system/pom.xml (72c5b40) > - recipes/service-discovery/pom.xml (a92c0c2) > - recipes/task-execution/pom.xml (0129ce7) > > View Diff <https://reviews.apache.org/r/13279/diff/> >
