> On Aug. 7, 2013, 1:04 a.m., Kishore Gopalakrishna wrote: > > why are the diff showing up as attachments? Makes it really hard to review
It's a workaround for INFRA-6640. We've been attaching diffs to get around not being able to upload diffs the normal way. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13364/#review24764 ----------------------------------------------------------- On Aug. 6, 2013, 10:37 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13364/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 10:37 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Description > ------- > > Fix typo in Idealstate property max_partitions_per_instance > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/13364/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > > https://reviews.apache.org/media/uploaded/files/2013/08/06/helix_2.diff > > > Thanks, > > Zhen Zhang > >
