----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13393/#review24849 -----------------------------------------------------------
Ship it! Ship It! - Zhen Zhang On Aug. 7, 2013, 11:45 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13393/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2013, 11:45 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-199 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-199. The new payload field for ZNRecord can cause > backwards-compatibility issues if it is allowed to publish even if it's null. > This fix ensures that rawPayload is only emitted if it is non-null. > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/ZNRecord.java 4e6080a > > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > 1504ff8 > > helix-core/src/test/java/org/apache/helix/manager/zk/serializer/TestJacksonPayloadSerializer.java > 0c4bc66 > > Diff: https://reviews.apache.org/r/13393/diff/ > > > Testing > ------- > > Tests pass locally. > > > Thanks, > > Kanak Biscuitwala > >
