> On Aug. 9, 2013, 6:27 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java, line > > 77 > > <https://reviews.apache.org/r/13437/diff/1/?file=339156#file339156line77> > > > > we should not allow null to be passed here.
done - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13437/#review24936 ----------------------------------------------------------- On Aug. 9, 2013, 3:55 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13437/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 3:55 a.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > [HELIX-197] state model leak > we are not removing state model from state model factory when resource are > dropped. this may lead to state model leak. fix this by passing > StateModelFactory to HelixStateTransitionHandler and let it remove state > model when toState is DROPPED. add test case for normal drop and drop > resource in ERROR state > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java > 2baa1cf > > helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java > 8287b46 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModel.java > e4df933 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java > 5267d6e > helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java > 5bc1fc0 > helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java 0910061 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java > e69de29 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java > d8f851e > > Diff: https://reviews.apache.org/r/13437/diff/ > > > Testing > ------- > > all tests pass locally > > > Thanks, > > Zhen Zhang > >
