----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13462/#review24963 -----------------------------------------------------------
Looks good to me. I'll sync up with you about HELIX-166 and 173 since those refactor the same stage. - Kanak Biscuitwala On Aug. 10, 2013, 3:24 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13462/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2013, 3:24 a.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > fix it by checking participant version when controller decides if sending > error->dropped transition message. if participant version is less then 0.6.1, > controller will not drop partition in error state. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java > aca0e74 > helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java > eaada16 > helix-core/src/main/resources/cluster-manager-version.properties 8a6db4c > > helix-core/src/test/java/org/apache/helix/integration/TestDropErrorPartition.java > e69de29 > > Diff: https://reviews.apache.org/r/13462/diff/ > > > Testing > ------- > > tests pass locally > > > Thanks, > > Zhen Zhang > >
