----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13700/#review25362 -----------------------------------------------------------
Ship it! helix-core/src/test/java/org/apache/helix/participant/statemachine/TestStateModelParser.java <https://reviews.apache.org/r/13700/#comment49758> whitespace - Kanak Biscuitwala On Aug. 21, 2013, 4:34 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13700/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 4:34 a.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > Currently the default error->dropped transition method in state model can > only be found using annotation. Should change the name to > onBecomeDroppedFromError() to follow the name convention so it can be found > by name convention as well. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModel.java > 014dce9 > > helix-core/src/test/java/org/apache/helix/participant/statemachine/TestStateModelParser.java > 0be990e > > Diff: https://reviews.apache.org/r/13700/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
