----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13748/#review25428 -----------------------------------------------------------
Ship it! Ship It! - Zhen Zhang On Aug. 22, 2013, 7:51 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13748/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 7:51 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-208 > > > Repository: helix-git > > > Description > ------- > > commit c149e00a56a03dfe0a924f6e6a393d9f912690f4 > Author: Kanak Biscuitwala <[email protected]> > Date: Thu Aug 22 12:36:27 2013 -0700 > > [HELIX-208] Add javadocs to classes and public methods in the model > package > > :100644 100644 7af017e... 58db71d... M > helix-core/src/main/java/org/apache/helix/model/AlertHistory.java > :100644 100644 d468473... d90ec1a... M > helix-core/src/main/java/org/apache/helix/model/AlertStatus.java > :100644 100644 02db44c... 506e3d5... M > helix-core/src/main/java/org/apache/helix/model/Alerts.java > :100644 100644 15c4345... f69a7ce... M > helix-core/src/main/java/org/apache/helix/model/ClusterConstraints.java > :100644 100644 be032af... 6f6b160... M > helix-core/src/main/java/org/apache/helix/model/ConstraintItem.java > :100644 100644 901ee10... 32854ab... M > helix-core/src/main/java/org/apache/helix/model/CurrentState.java > :100644 100644 b9b6ddf... 7744b91... M > helix-core/src/main/java/org/apache/helix/model/Error.java > :100644 100644 fd5c79a... d5f1afc... M > helix-core/src/main/java/org/apache/helix/model/ExternalView.java > :100644 100644 42ac339... b884534... M > helix-core/src/main/java/org/apache/helix/model/HealthStat.java > :100644 100644 a8034de... 9d3b41a... M > helix-core/src/main/java/org/apache/helix/model/HelixConfigScope.java > :100644 100644 b0b3960... 463369a... M > helix-core/src/main/java/org/apache/helix/model/IdealState.java > :100644 100644 62f52a6... eb1c652... M > helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java > :100644 100644 8e57143... d57fb52... M > helix-core/src/main/java/org/apache/helix/model/LeaderHistory.java > :100644 100644 584f5b9... 75e0cf3... M > helix-core/src/main/java/org/apache/helix/model/LiveInstance.java > :100644 100644 4a35152... d599b8b... M > helix-core/src/main/java/org/apache/helix/model/Message.java > :100644 100644 0c8b9aa... 1d694ab... M > helix-core/src/main/java/org/apache/helix/model/Partition.java > :100644 100644 4c02546... 1d6706a... M > helix-core/src/main/java/org/apache/helix/model/PauseSignal.java > :100644 100644 e028e66... 9cd1934... M > helix-core/src/main/java/org/apache/helix/model/PersistentStats.java > :100644 100644 b6ffea7... 1544514... M > helix-core/src/main/java/org/apache/helix/model/Resource.java > :100644 100644 31224d5... 7f08b6f... M > helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java > :100644 100644 d65a333... f4857ee... M > helix-core/src/main/java/org/apache/helix/model/StatusUpdate.java > :100644 100644 2bbec41... 2151c44... M > helix-core/src/main/java/org/apache/helix/model/Transition.java > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/model/AlertHistory.java 7af017e > helix-core/src/main/java/org/apache/helix/model/AlertStatus.java d468473 > helix-core/src/main/java/org/apache/helix/model/Alerts.java 02db44c > helix-core/src/main/java/org/apache/helix/model/ClusterConstraints.java > 15c4345 > helix-core/src/main/java/org/apache/helix/model/ConstraintItem.java be032af > helix-core/src/main/java/org/apache/helix/model/CurrentState.java 901ee10 > helix-core/src/main/java/org/apache/helix/model/Error.java b9b6ddf > helix-core/src/main/java/org/apache/helix/model/ExternalView.java fd5c79a > helix-core/src/main/java/org/apache/helix/model/HealthStat.java 42ac339 > helix-core/src/main/java/org/apache/helix/model/HelixConfigScope.java > a8034de > helix-core/src/main/java/org/apache/helix/model/IdealState.java b0b3960 > helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java 62f52a6 > helix-core/src/main/java/org/apache/helix/model/LeaderHistory.java 8e57143 > helix-core/src/main/java/org/apache/helix/model/LiveInstance.java 584f5b9 > helix-core/src/main/java/org/apache/helix/model/Message.java 4a35152 > helix-core/src/main/java/org/apache/helix/model/Partition.java 0c8b9aa > helix-core/src/main/java/org/apache/helix/model/PauseSignal.java 4c02546 > helix-core/src/main/java/org/apache/helix/model/PersistentStats.java > e028e66 > helix-core/src/main/java/org/apache/helix/model/Resource.java b6ffea7 > helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java > 31224d5 > helix-core/src/main/java/org/apache/helix/model/StatusUpdate.java d65a333 > helix-core/src/main/java/org/apache/helix/model/Transition.java 2bbec41 > > Diff: https://reviews.apache.org/r/13748/diff/ > > > Testing > ------- > > Tests pass locally > > > Thanks, > > Kanak Biscuitwala > >
