----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13694/ -----------------------------------------------------------
(Updated Aug. 22, 2013, 10:35 p.m.) Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. Changes ------- Removed some additional dead code. Bugs: HELIX-212 Repository: helix-git Description ------- Fix for HELIX-212. The interface was changed to a single function and integrated into the controller stages. This led to some uncovered shortcomings in the rebalancing strategy, some of which are fixed here, and others are tracked by other issues. Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/HelixProperty.java 2e19231 helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 4dd5ea6 helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 17dc5c8 helix-core/src/main/java/org/apache/helix/controller/rebalancer/Rebalancer.java a0cfbb7 helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java bc682ff helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java 3fd52f4 helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 598c318 helix-core/src/main/java/org/apache/helix/controller/stages/RebalanceIdealStateStage.java cf1633c helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java 76560a4 helix-core/src/main/java/org/apache/helix/model/IdealState.java b0b3960 helix-core/src/main/java/org/apache/helix/model/ResourceMapping.java PRE-CREATION helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java 7811c0d Diff: https://reviews.apache.org/r/13694/diff/ Testing ------- Tests pass locally. Thanks, Kanak Biscuitwala
