----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14578/#review26899 -----------------------------------------------------------
Ship it! looks good! - Zhen Zhang On Oct. 10, 2013, 6:03 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14578/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2013, 6:03 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-268 > > > Repository: helix-git > > > Description > ------- > > This is still on the helix-logical-model branch, but I thought I would create > a review to increase readability. Here is an implementation of atomic > accessors by way of locks. It uses the ZooKeeper lock recipe as its > underlying implementation. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicClusterAccessor.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicParticipantAccessor.java > PRE-CREATION > > helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java > PRE-CREATION > helix-core/src/main/java/org/apache/helix/lock/HelixLock.java PRE-CREATION > helix-core/src/main/java/org/apache/helix/lock/HelixLockable.java > PRE-CREATION > helix-core/src/main/java/org/apache/helix/lock/zk/ZKHelixLock.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/api/accessor/TestAccessorRecreate.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/api/accessor/TestAtomicAccessors.java > PRE-CREATION > helix-core/src/test/java/org/apache/helix/lock/zk/TestZKHelixLock.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/14578/diff/ > > > Testing > ------- > > Wrote and ran the tests included in this review. Locking/blocking and > recreation appear to work correctly based on these tests. > > > Thanks, > > Kanak Biscuitwala > >
