----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15352/#review28555 -----------------------------------------------------------
Do we have a test case, that ensures that no exception is thrown if id is not set ? is it good to allow not having an id? helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java <https://reviews.apache.org/r/15352/#comment55353> why is this called dummy? can we use a better naming helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java <https://reviews.apache.org/r/15352/#comment55354> why do we need to copy into another znrecord, can we not return dummy( we need to rename this variable) - Kishore Gopalakrishna On Nov. 8, 2013, 5:35 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15352/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2013, 5:35 p.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-292 > > > Repository: helix-git > > > Description > ------- > > commit ebf522762e140959263f700ab1ea1e2887471aa9 > Author: Kanak Biscuitwala <[email protected]> > Date: Fri Nov 8 09:31:48 2013 -0800 > > [HELIX-292] ZNRecordStreamingSerializer should not assume id comes first > > :100644 100644 f97774e... 47e0d38... M > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > :100644 100644 2f5a28b... 75a2e8c... M > helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java > f97774e > > Diff: https://reviews.apache.org/r/15352/diff/ > > > Testing > ------- > > The controller won't throw NPEs anymore when a Python participant creates > JSON that doesn't put id first. > > > Thanks, > > Kanak Biscuitwala > >
