----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15603/#review29000 -----------------------------------------------------------
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java <https://reviews.apache.org/r/15603/#comment56045> what happens if there is exception here? you probably need another try catch with empty catch block. - Kishore Gopalakrishna On Nov. 15, 2013, 10:49 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15603/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 10:49 p.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-264] fix zkclient#close() bug, port fix to 0.6.1.5-release > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java > eec38aa > helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java 41fde0c > helix-core/src/test/java/org/apache/helix/ZkTestHelper.java 37b0664 > > helix-core/src/test/java/org/apache/helix/integration/TestExceptionInStateModelReset.java > PRE-CREATION > helix-core/src/test/java/org/apache/helix/manager/zk/TestZkFlapping.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15603/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
