> On Dec. 4, 2013, 11:04 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java, > > line 49 > > <https://reviews.apache.org/r/16006/diff/1/?file=393917#file393917line49> > > > > remove controller from the method names since the class name already > > has it
Done > On Dec. 4, 2013, 11:04 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java, > > line 101 > > <https://reviews.apache.org/r/16006/diff/1/?file=393917#file393917line101> > > > > controller context is created once per pipeline or is shared across > > invocations ? It's read at the start of a pipeline (i.e. ReadClusterDataStage), and persisted at the end. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16006/#review29743 ----------------------------------------------------------- On Dec. 4, 2013, 10:50 a.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16006/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 10:50 a.m.) > > > Review request for helix, Zhen Zhang and Kishore Gopalakrishna. > > > Bugs: HELIX-333 > > > Repository: helix-git > > > Description > ------- > > commit 57d0826b4c4fce616aed5ad21034ba8c81104d67 > Author: Kanak Biscuitwala <[email protected]> > Date: Wed Dec 4 10:44:19 2013 -0800 > > [HELIX-333] Support remove in ControllerContextProvider > > :100644 100644 1541585... 51b90c2... M > helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java > :100644 100644 e63041a... 7c2cc0f... M > helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java > 1541585 > > helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java > e63041a > > Diff: https://reviews.apache.org/r/16006/diff/ > > > Testing > ------- > > Tests pass locally. > > > Thanks, > > Kanak Biscuitwala > >
