----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16017/#review29763 -----------------------------------------------------------
Ship it! Fantastic, love this. - Kishore Gopalakrishna On Dec. 4, 2013, 9:44 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16017/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 9:44 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-22 > > > Repository: helix-git > > > Description > ------- > > commit 4431f9aeb0e00130211b4e4bc8139b612b626e14 > Author: Kanak Biscuitwala <[email protected]> > Date: Wed Dec 4 13:00:20 2013 -0800 > > [HELIX-22] Remove dependency on josql > > :100644 100644 6f2aeb9... f30abac... M helix-core/pom.xml > :100644 100644 da2b36e... 75781e1... M > helix-core/src/main/java/org/apache/helix/Criteria.java > :100644 000000 bac2b15... 0000000... D > helix-core/src/main/java/org/apache/helix/josql/ClusterJosqlQueryProcessor.java > :100644 000000 f2fbddb... 0000000... D > helix-core/src/main/java/org/apache/helix/josql/ZNRecordJosqlFunctionHandler.java > :100644 000000 108596f... 0000000... D > helix-core/src/main/java/org/apache/helix/josql/ZNRecordRow.java > :100644 000000 550d569... 0000000... D > helix-core/src/main/java/org/apache/helix/josql/package-info.java > :100644 100644 3d2569e... 9ca20af... M > helix-core/src/main/java/org/apache/helix/messaging/CriteriaEvaluator.java > :000000 100644 0000000... 5a2effd... A > helix-core/src/main/java/org/apache/helix/messaging/ZNRecordRow.java > :100644 000000 30c23fb... 0000000... D > helix-core/src/test/java/org/apache/helix/josql/TestClusterJosqlQueryProcessor.java > :100644 000000 2aa4544... 0000000... D > helix-core/src/test/java/org/apache/helix/josql/TestJosqlProcessor.java > :100644 100644 11bdeb5... e82a4a8... M > helix-core/src/test/java/org/apache/helix/messaging/TestDefaultMessagingService.java > :100644 100644 010023c... 5c17bd1... M pom.xml > > > Diffs > ----- > > helix-core/pom.xml 6f2aeb9 > helix-core/src/main/java/org/apache/helix/Criteria.java da2b36e > > helix-core/src/main/java/org/apache/helix/josql/ClusterJosqlQueryProcessor.java > bac2b15 > > helix-core/src/main/java/org/apache/helix/josql/ZNRecordJosqlFunctionHandler.java > f2fbddb > helix-core/src/main/java/org/apache/helix/josql/ZNRecordRow.java 108596f > helix-core/src/main/java/org/apache/helix/josql/package-info.java 550d569 > helix-core/src/main/java/org/apache/helix/messaging/CriteriaEvaluator.java > 3d2569e > helix-core/src/main/java/org/apache/helix/messaging/ZNRecordRow.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/josql/TestClusterJosqlQueryProcessor.java > 30c23fb > helix-core/src/test/java/org/apache/helix/josql/TestJosqlProcessor.java > 2aa4544 > > helix-core/src/test/java/org/apache/helix/messaging/TestDefaultMessagingService.java > 11bdeb5 > pom.xml 010023c > > Diff: https://reviews.apache.org/r/16017/diff/ > > > Testing > ------- > > Tests pass locally, added a couple more cases. > > > Thanks, > > Kanak Biscuitwala > >
