----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16199/ -----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Bugs: HELIX-344 Repository: helix-git Description ------- commit f3374f6d75c6f86d710fdacc7c0166a26538cead Author: Kanak Biscuitwala <[email protected]> Date: Wed Dec 11 17:41:25 2013 -0800 [HELIX-344] Add app-specific ideal state validation :100644 100644 0874958... ace97a9... M helix-core/src/main/java/org/apache/helix/PropertyKey.java :100644 100644 8e4e1ea... 7a8b609... M helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java :100644 100644 b90880e... 6803762... M helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java :000000 100644 0000000... 9d56337... A helix-core/src/main/java/org/apache/helix/controller/stages/ResourceValidationStage.java :100644 100644 9d3b41a... 7791c91... M helix-core/src/main/java/org/apache/helix/model/HelixConfigScope.java :000000 100644 0000000... f40f45e... A helix-core/src/main/java/org/apache/helix/model/IdealStateSpec.java :100644 100644 abf75be... 0752481... M helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java :000000 100644 0000000... 5e098da... A helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceValidationStage.java :100644 100644 e0c8b6f... 0acd775... M helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java :000000 100644 0000000... fd6eb05... A helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java Diffs ----- helix-core/src/main/java/org/apache/helix/PropertyKey.java 0874958 helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java 8e4e1ea helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java b90880e helix-core/src/main/java/org/apache/helix/controller/stages/ResourceValidationStage.java PRE-CREATION helix-core/src/main/java/org/apache/helix/model/HelixConfigScope.java 9d3b41a helix-core/src/main/java/org/apache/helix/model/IdealStateSpec.java PRE-CREATION helix-core/src/test/java/org/apache/helix/ZkUnitTestBase.java abf75be helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceValidationStage.java PRE-CREATION helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java e0c8b6f helix-core/src/test/java/org/apache/helix/integration/TestInvalidResourceRebalance.java PRE-CREATION Diff: https://reviews.apache.org/r/16199/diff/ Testing ------- Existing tests pass, added unit and integration tests. Thanks, Kanak Biscuitwala
