----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16402/ -----------------------------------------------------------
(Updated Dec. 23, 2013, 4:30 p.m.) Review request for helix, Zhen Zhang and Kishore Gopalakrishna. Changes ------- Updated diff. No longer spawning new threads, but using the same strategy as in the 0.6 branch. Also un-deprecating ClusterDataCache to reduce code duplication. Bugs: HELIX-345 Repository: helix-git Description ------- Optimized the following: - cached messages across pipeline runs - cached the HelixRebalancer instance for each resource - spawned threads to read resources and participants in parallel - started using caching and batching when persisting resource assignments - instrumented all pipeline stages with the timing logs commit 5758421ce71c37118423a543bf15569f4c697019 Author: Kanak Biscuitwala <[email protected]> Date: Thu Dec 19 13:52:56 2013 -0800 [HELIX-345] Speed up the controller pipelines for 0.7 :100644 100644 36c7aaa... 38da1b9... M helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java :100644 100644 ec812b2... fcbf45f... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java :100644 100644 532ecb5... 6cdd304... M helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java :100644 100644 8235173... a888dc7... M helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java :100644 100644 ef5a5fd... 97734a6... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java :100644 100644 966160c... 0ce132b... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java :100644 100644 764b422... f941826... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java :100644 100644 45fc355... fd37a2f... M helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java :100644 100644 7c2cc0f... ece4209... M helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java :100644 100644 2279d76... 378eb61... M helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java :100644 100644 5b75535... f141aa3... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java :100644 100644 470de2c... fbc75be... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceValidationStage.java :100644 100644 c48f156... 5a4bd2d... M helix-core/src/main/java/org/apache/helix/controller/stages/StatsAggregationStage.java :100644 100644 471530c... a530836... M helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java :100644 100644 9ec1ef9... 2d577ca... M helix-core/src/main/java/org/apache/helix/tools/YAMLClusterSetup.java :100644 100644 919eb00... a89d27f... M helix-core/src/test/java/org/apache/helix/Mocks.java Diffs (updated) ----- helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java 36c7aaa helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java ec812b2 helix-core/src/main/java/org/apache/helix/controller/stages/ClusterDataCache.java 6f09d26 helix-core/src/main/java/org/apache/helix/controller/stages/CompatibilityCheckStage.java 532ecb5 helix-core/src/main/java/org/apache/helix/controller/stages/CurrentStateComputationStage.java 8235173 helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java ef5a5fd helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java 966160c helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java 764b422 helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java 45fc355 helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java 7c2cc0f helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java 2279d76 helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java 5b75535 helix-core/src/main/java/org/apache/helix/controller/stages/ResourceValidationStage.java 470de2c helix-core/src/main/java/org/apache/helix/controller/stages/StatsAggregationStage.java c48f156 helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java 471530c helix-core/src/main/java/org/apache/helix/tools/YAMLClusterSetup.java 9ec1ef9 helix-core/src/test/java/org/apache/helix/Mocks.java 919eb00 Diff: https://reviews.apache.org/r/16402/diff/ Testing ------- Tests pass locally. Reading the cluster is up to 30% faster. Thanks, Kanak Biscuitwala
