srkukarni commented on a change in pull request #2891: [WIP] Refactor StatefulStorage URL: https://github.com/apache/incubator-heron/pull/2891#discussion_r186254708
########## File path: heron/proto/ckptmgr.proto ########## @@ -171,7 +175,25 @@ message CleanStatefulCheckpointResponse { repeated string cleaned_checkpoint_ids = 2; } -// stmgr -> ckptmgr messages +/* + * stmgr -> ckptmgr messages + */ + +// This message encapsulates the info associated with +// state of an instance/partition +message InstanceStateCheckpoint { + required string checkpoint_id = 1; + required bytes state = 2; + // A version string that can be specified by user. It can be used to translate + // checkpoint data from older versions to the latest version when necessary. + optional string data_version = 3; +} + +// This message encapsulates the info associated with +// checkpoint metadata of a component +message CheckpointComponentMetadata { + required int32 parallelism = 1; Review comment: is there any documentation that describes whats this pr aims to do? Without it its very hard to understand whats going on ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services