[
https://issues.apache.org/jira/browse/HIVE-1750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927641#action_12927641
]
Namit Jain commented on HIVE-1750:
----------------------------------
1. More comments for NodeInfoWrapper
2. Why is it public ?
3. Why do you need wlkEvalExpr
Line 294: ExprProcFactory
ExprNodeConstantDesc falseDesc = new ExprNodeConstantDesc(
wrapper.outExpr.getTypeInfo(), Boolean.TRUE);
return new NodeInfoWrapper(WalkState.TRUE, null, falseDesc,
falseDesc);
Change variable name
313:
for (Object child : nodeOutputs) {
NodeInfoWrapper child_nd = (NodeInfoWrapper) child;
if (c == 0) {
c1 = (NodeInfoWrapper) child;
c = 1;
}
c2 = (NodeInfoWrapper) child;
}
This code is way more complicated than:
c1 = nodeOutputs[0]
c2 = nodeOutputs[1]
334:
for (int i = 0; i < ctx.getPartList().size(); i++) {
results[i] = opOr(c1.ResultVector[i], c2.ResultVector[i]);
shouldn't it be opAnd()
OpProcFactory:153
if (wrapper.state == ExprProcFactory.WalkState.TRUE) {
//top.setChildOperators(fop.getChildOperators());
You can use Operator.removeChild()
> Remove Partition Filtering Conditions when Possible
> ---------------------------------------------------
>
> Key: HIVE-1750
> URL: https://issues.apache.org/jira/browse/HIVE-1750
> Project: Hive
> Issue Type: Improvement
> Reporter: Siying Dong
> Assignee: Siying Dong
> Attachments: HIVE-1750.1.patch, HIVE-1750.2.patch
>
>
> For some simple queries, partition filtering constraints take 8% of CPU time
> (now 16% since we filter twice) even if the result is always true. When
> possible, we should remove these constraints to save CPU times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
