[ https://issues.apache.org/jira/browse/HIVE-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-1785: ----------------------------- Fix Version/s: 0.7.0 Affects Version/s: 0.7.0 Status: Open (was: Patch Available) * It looks like you mixed in some changes from other patches? (And the patch name is HIVE-1758 instead of HIVE-1785.) Please resubmit with only the changes relevant to HIVE-1785. Also, I don't see where you addressed two of my previous comments: * rewrite existing hook implementations in Hive codebase to implement new interface * add Javadoc for Hook, HookContext, and ExecuteWithHookContext One new one while we're at it: * The old hook interface provided SessionState, Set<ReadEntity>, Set<WriteEntity>, LineageInfo and UserGroupInformation. HookContext should provide getters for these as well. I realize that some of these are obtainable via QueryPlan and HiveConf, but we should not force users to become dependent on internals like QueryPlan unless they want to be; also, providing the equivalent getters makes upgrade to the new interface easier. You can make the HookContext getters call through to QueryPlan getters etc. > change Pre/Post Query Hooks to take in 1 parameter: HookContext > --------------------------------------------------------------- > > Key: HIVE-1785 > URL: https://issues.apache.org/jira/browse/HIVE-1785 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Affects Versions: 0.7.0 > Reporter: Namit Jain > Assignee: Liyin Tang > Fix For: 0.7.0 > > Attachments: hive-1785_3.patch, hive-1785_4.patch, hive_1758_5.patch, > hive_1785_1.patch, hive_1785_2.patch > > > This way, it would be possible to add new parameters to the hooks without > changing the existing hooks. > This will be a incompatible change, and all the hooks need to change to the > new API -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.