----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/210/#review84 -----------------------------------------------------------
http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/SessionConfStore.java <https://reviews.apache.org/r/210/#comment154> I think this should be HiveConf instead of Configuration. http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/SessionConfStore.java <https://reviews.apache.org/r/210/#comment153> I think you can simplify the interface by making getSessionConfStore() private, and then calling it from getConf() and setConf() which can now be made static. Then you'll be able to call SessionConfStore.getConf() instead of SessionConfStore.getSessionConfStore().getConf() http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml <https://reviews.apache.org/r/210/#comment155> I don't understand the motivation for this change, but assuming that FsShell provides features unavailable in FileSystem, is there any reason why we can't replace the FileSystem based implementation with the new one that uses FsShell? - Carl On 2011-01-04 16:41:46, Carl Steinbach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/210/ > ----------------------------------------------------------- > > (Updated 2011-01-04 16:41:46) > > > Review request for hive. > > > Summary > ------- > > Review > https://issues.apache.org/jira/secure/attachment/12467491/HIVE-1881.1.patch > > > This addresses bug HIVE-1881. > https://issues.apache.org/jira/browse/HIVE-1881 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > 1055171 > > http://svn.apache.org/repos/asf/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/SessionConfStore.java > PRE-CREATION > http://svn.apache.org/repos/asf/hive/trunk/conf/hive-default.xml 1055171 > > http://svn.apache.org/repos/asf/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > 1055171 > > http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java > 1055171 > > Diff: https://reviews.apache.org/r/210/diff > > > Testing > ------- > > > Thanks, > > Carl > >
