[
https://issues.apache.org/jira/browse/HIVE-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977594#action_12977594
]
Carl Steinbach commented on HIVE-1881:
--------------------------------------
I'm concerned that this patch introduces two new configuration properties that
don't make sense
to anyone outside of Facebook. I think we need to avoid doing this since it
makes the configuration
process more complicated (it's already complicated enough), and also introduces
an untested
code path.
Instead, I'd like to propose that we define a MetaStoreFs interface that
defines createDir and
deleteDir methods, etc, along with a default implementation and the ability to
plug in other
implementations by setting a new hive.metastore.fs.impl configuration property.
What do you think?
> Add an option to use FsShell to delete dir in warehouse
> -------------------------------------------------------
>
> Key: HIVE-1881
> URL: https://issues.apache.org/jira/browse/HIVE-1881
> Project: Hive
> Issue Type: Improvement
> Components: Metastore
> Reporter: He Yongqiang
> Assignee: He Yongqiang
> Attachments: HIVE-1881.1.patch
>
>
> >>@Yongqiang: What's the motivation for doing this?
> This is to work with some internal hacky codes about doing delete. There
> should be no impact if you use open source hadoop.
> But the idea here is to give users 2 options to do the delete. In Facebook,
> we have some customized code in FsShell which can control whether the delete
> should go through trash or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
