[
https://issues.apache.org/jira/browse/HIVE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992822#comment-12992822
]
John Sichi commented on HIVE-1803:
----------------------------------
Some review comments:
* Need to factor out all that code duplicated from compact index handler; share
it in package org.apache.hadoop.hive.ql.index. Use abstract classes in cases
where behavior needs to be overridden, otherwise, just share concrete classes
there.
* If we're going to publish the new UDF's as visible out of the box (not just
internal to the index implementation) then they need unit tests of their own,
as well as some documentation about the representation on which they operate
(maybe best to wait and see how compression shakes out first). Also, for the
ones that turn out to be not generally applicable, then they need to be named
more specifically.
* For dense bitmaps, I think you can probably use java.util.BitSet instead of
rolling so much of your own (at least for ones where you have control over the
bit array representation)
* The name attribute in the annotation for GenericUDAFCollectBitmapSet is
incorrect.
* In HiveIndex.java, the symbol should be just BITMAP_TABLE (not
BITMAP_SUMMARY_TABLE) since the bitmap is actually quite detailed.
> Implement bitmap indexing in Hive
> ---------------------------------
>
> Key: HIVE-1803
> URL: https://issues.apache.org/jira/browse/HIVE-1803
> Project: Hive
> Issue Type: New Feature
> Reporter: Marquis Wang
> Assignee: Marquis Wang
> Attachments: HIVE-1803.1.patch, HIVE-1803.2.patch,
> bitmap_index_1.png, bitmap_index_2.png
>
>
> Implement bitmap index handler to complement compact indexing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
